Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bounding box estimation for RealTransformed RealIntervals #37

Merged
merged 7 commits into from
Jun 15, 2024

Conversation

bogovicj
Copy link
Contributor

  • add a test

@bogovicj
Copy link
Contributor Author

This commit provides the functionality discussed in #6

Needs a new release of imglib2 including imglib/imglib2@33c4661

@bogovicj bogovicj marked this pull request as draft April 12, 2022 20:29
* fills spacing argument if few than numDims provided
@bogovicj
Copy link
Contributor Author

bogovicj commented Aug 9, 2022

This is waiting on a new imglib2 core release as it depends on imglib/imglib2@33c4661

@tpietzsch
Copy link
Member

@bogovicj I did not look in depth at the code, so forgive me if this is already taken care of...

It seems to me, that there can be unfavourable cases, when for example the sampled interval would be 19x19, and the spacing would be 10. Then the max point that would be checked is (10, 10), when we would prefer to also check the actual max corner at (19, 19). I think this is what happens with the current LocalizingRealIntervalIterator. Would it make sense to add an option to always include the max's, independent of sampling?

A variant of this is that something similar could happen due to rounding errors with real coordinates, even if the spacing is chosen well-intentioned.

@ctrueden
Copy link
Member

@bogovicj I rebased this over the latest master branch. It does not compile right now though due to API skew.

bogovicj and others added 2 commits March 25, 2024 14:13
…ransform into realTransformBbox

# Conflicts:
#	pom.xml
#	src/main/java/net/imglib2/util/RealIntervals.java
#	src/test/java/net/imglib2/util/RealIntervalsTests.java
@axtimwalde axtimwalde marked this pull request as ready for review June 13, 2024 16:44
with extensible interface for sampling method,
override trivial cases in Translations, scales, and
affine transformations
@axtimwalde axtimwalde merged commit ce8f984 into imglib:master Jun 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants